Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding delay between dials #1973

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix: adding delay between dials #1973

merged 3 commits into from
Apr 24, 2024

Conversation

gabrielmer
Copy link
Contributor

Problem

In unit testing, after a node fails to connect to another node in a different cluster, the node fails to connect to a node in its same cluster and shard immediately after the failure.

Temporarily adding a small delay between dials until the root cause is found.

Issue

waku-org/nwaku#2621

@gabrielmer gabrielmer self-assigned this Apr 23, 2024
@gabrielmer gabrielmer requested a review from a team as a code owner April 23, 2024 16:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 180.77 KB (0%) 3.7 s (0%) 741 ms (+26.29% 🔺) 4.4 s
Waku Simple Light Node 180.85 KB (0%) 3.7 s (0%) 486 ms (-9.14% 🔽) 4.2 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 184 ms (+58.91% 🔺) 646 ms
Symmetric encryption 22.57 KB (0%) 452 ms (0%) 139 ms (-33.86% 🔽) 590 ms
DNS discovery 72.44 KB (0%) 1.5 s (0%) 464 ms (+21.09% 🔺) 2 s
Peer Exchange discovery 73.96 KB (0%) 1.5 s (0%) 446 ms (+15.02% 🔺) 2 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 259 ms (-30.91% 🔽) 1.7 s
Privacy preserving protocols 38.78 KB (0%) 776 ms (0%) 225 ms (-21.81% 🔽) 1000 ms
Waku Filter 111.38 KB (0%) 2.3 s (0%) 451 ms (+48.93% 🔺) 2.7 s
Waku LightPush 110.15 KB (0%) 2.3 s (0%) 504 ms (+15.78% 🔺) 2.8 s
History retrieval protocols 110.66 KB (0%) 2.3 s (0%) 466 ms (+18.73% 🔺) 2.7 s
Deterministic Message Hashing 4.83 KB (0%) 97 ms (0%) 13 ms (+6% 🔺) 109 ms

@fbarbu15 fbarbu15 merged commit 80a9525 into master Apr 24, 2024
8 of 10 checks passed
@fbarbu15 fbarbu15 deleted the fix-getPeers-tests branch April 24, 2024 16:18
@danisharora099
Copy link
Collaborator

#1977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adklempner adklempner adklempner approved these changes

Assignees

@gabrielmer gabrielmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielmer @danisharora099 @adklempner @fbarbu15